Letting diapers soak in anything for days isn't good for them, being wet (except hemp) makes fabric more fragile. Most everything harms fabrics with that much exposure. Vinegar may be the least damaging. Oxiclean quits being active after a few hours and does break down fabric.
But just the diaper bacteria will really hurt fabrics waiting that long to wash. They fabric eating bacteria are almost nonexistent the first 48 hours and then multiply very quickly.
I understand it's often just what works to wash more seldom, just putting the info out there. I wonder whether a capful of bleach might be less harmful than letting bacteria multiply. Or keep at it with the vinegar.
For overnight, I Love washing soda.